Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worksheet): add organizationId and workspaceId to worksheet #3345

Merged

Conversation

CHLK
Copy link
Collaborator

@CHLK CHLK commented Sep 11, 2024

What type of PR is this?

type-feature

What this PR does / why we need it:

add organizationId and workspaceId to worksheet

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@CHLK CHLK added the type-feature The functionality to be implemented label Sep 11, 2024
@CHLK CHLK self-assigned this Sep 11, 2024
@CHLK CHLK modified the milestone: ODC 4.3.2 Sep 11, 2024
@CHLK CHLK changed the title feat(worksheet): add organizationId and groupId to worksheet feat(worksheet): add organizationId and workspaceId to worksheet Sep 13, 2024
@yizhouxw yizhouxw modified the milestones: ODC 4.3.2, obcloud_202410 Sep 13, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit a5edfb7 into dev/obcloud_ap_202410 Sep 14, 2024
7 checks passed
@yhilmare yhilmare deleted the feat/keyang_ap_202410_add_group_to_worksheet branch September 14, 2024 02:09
yhilmare pushed a commit that referenced this pull request Sep 25, 2024
* feat(worksheet): add organizationId and groupId to worksheet

* feat(worksheet): change groupId in worksheet to workspaceId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature The functionality to be implemented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants