-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Egeria Intellij build failure #7324
Comments
Locally I can build core Egeria and get a valid generated file TestBeansToAccessOMRS.java. |
I
The resultant build was clean I inspected the file, and at line 126766 of TestBeansToAccessOMRS.java I see
which reports no errors - but also different content on the line to the error you are reporting. I do have many declarations of primitivePropertyValueForMap in the file, and also in this method testCreateAgreementItem() it is declared 4 times
But the end result is
I had left my JVM at default. On checking, I am using 'temurin 17' - and the language level defaulted to 17 (this is something I usually check/change after importing a project The editor marks this file as 'you are editing a file which is ignored' - which is good, since intelliJ knows this file is generated Additionally, there are no graphical overlays on main/java or main/test - ie IntelliJ is not seeing these as source modules (and so wouldn't try to compile, or report any issues), but arguably this is also true, since they are generated and just an intermediate step of the build process. So it would seem there are maybe two issues
@davidradl @MihaiIliescu is the sequence I followed exactly the same as you? |
For the gradle build, no code has been added to build/execute these tests at all - I missed this when doing the port |
I think I have found a bug in the generator - just testing. |
I'm looking at why the tests don't run in our build. I can't see anything changed in maven for years . |
@planetf1 I will not merge until you give me the nod. @MihaiIliescu you could try applying the pr locally and test it works if you like |
I have fixed up gradle to actually build the tests. |
yes, I'll test it now |
Just finished testing #7325. Pulled David's PR, ran mvn clean install, and then build from Intellij with no errors. Great work! |
There's a new PR #7327 which incorporates David's fix, but also corrects the gradle build to actually run the tests! It was ready to merge, but blocked by many code style warnings from codeQL. Awaiting a decision as to what to do with those before we merge. with the pending change to v4 I suggest this waits until after that (Monday 6 Feb) |
Though not directly related, I am intrigued if #7425 would make any difference |
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
#7324 Ensure Open Types tests are run (gradle)
This should be fixed now, though note issue #7536 |
Existing/related issue?
No response
Current Behavior
I pulled the up to date egeria repo from main and after the maven build I tried to run the build from the intellij interface and I got an error:
~/egeria/open-metadata-test/open-metadata-fvt/open-types-fvt/open-types-test/src/test/java/org/odpi/openmetadata/fvt/opentypes/server/TestBeansToAccessOMRS.java:126766:36
java: variable primitivePropertyValueForMap is already defined in method testCreateAgreementItem()
The class that fails is generated code and declares multiple times the same variable.
The issue is not only on my setup, I checked with a colleague and we got the error.
Expected Behavior
The build finishes successfully.
Steps To Reproduce
No response
Environment
Any Further Information?
No response
The text was updated successfully, but these errors were encountered: