Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 4 - switch dev over (POM removal remains) #7330

Closed
12 tasks done
planetf1 opened this issue Jan 31, 2023 · 6 comments
Closed
12 tasks done

Version 4 - switch dev over (POM removal remains) #7330

planetf1 opened this issue Jan 31, 2023 · 6 comments
Assignees
@planetf1

Comments

@planetf1
Copy link
Member

planetf1 commented Jan 31, 2023 •
edited
Loading

Following release 3.15 we will move over to development of Egeria version 4.
This will require a change to use Java 17 & build off gradle

This issue will track the immediate changes required.
The starting point will be a post-release 3.15 update to 3.16 SNAPSHOT

  • Get agreement on dev community call that this work can now begin
  • Mailing list, slack, github discussions announce of start of work & need to use java 17/gradle
  • Update egeria-release-4.0pre from main via rebase (check clean)
  • Merge in changes from egeria-release-4.0pre back to main
  • Disable v4 github actions on egeria-release-4.0pre
  • Update version in main from 3.16-SNAPSHOT to 4.0-SNAPSHOT
  • Mailing list, slack, github discussions announce of need to use java 17/gradle
  • Test cts
  • Test notebooks
  • Ensure docs updated
  • Remove maven pom files
  • Check other scans - codeql, dependencies etc

Additional work will then be required in other repositories to bring them up to the current levels ie connectors that pull in base egeria libraries.
@planetf1 planetf1 self-assigned this Jan 31, 2023
@planetf1
Copy link
Member Author

planetf1 commented Feb 3, 2023 •
edited
Loading

We are starting this switch on MONDAY 6 Feb 2023
Maven POMS will not be delete for the first stage

@planetf1 planetf1 mentioned this issue Feb 3, 2023
Closed
25 tasks
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 5, 2023
@planetf1
odpi#7330 Additional updates to workflows for v4 switchover
92dc8b2 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 5, 2023
@planetf1
odpi#7330 updates to gradle properties
ef12e35 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1
Copy link
Member Author

planetf1 commented Feb 6, 2023

v4 changes merged.

One issue noticed on build

> Task :open-metadata-test:open-metadata-fvt:view-services-fvt:glossary-author-fvt:publishMavenmodulePublicationToMavenLocal
Multiple publications with coordinates 'org.odpi.egeria:glossary-author-fvt:4.0-SNAPSHOT' are published to repository 'mavenLocal'. The publications 'mavenmodule' in project ':open-metadata-test:open-metadata-fvt:access-services-fvt:glossary-author-fvt' and 'mavenmodule' in project ':open-metadata-test:open-metadata-fvt:view-services-fvt:glossary-author-fvt' will overwrite each other!

@planetf1
Copy link
Member Author

planetf1 commented Feb 6, 2023

This was caused by incomplete moving of the glossary-author-fvt from access-services to view-services - there was a old reference in settings.gradle.

planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 fix dup glossary-author-fvt artifact reference in settings.…
3bb6357 
…gradle

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 mentioned this issue Feb 6, 2023
Merged
@planetf1
Copy link
Member Author

planetf1 commented Feb 6, 2023 •
edited
Loading

Another issue noted.

The build is set to

  • read/write to cache for builds on main
  • read only from cache for PR builds

If a PR is submitted which can be satisfied purely from cache, then when the codeQL workflow attempts to run,
it finds no code to use...

The fixes are to do one of:

  • Not use codeQL
  • make codeQL non-mandatory (ie it's not checked for allowing PR to be merged)
  • Add ability for user to ignore codeQL failure
  • selectively use codeQL action based on what files change (very hard to specify)
  • Disable caching for codeQL build (increases build time)

planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 Disable caching for codeQL workflow as full before/after co…
3cfb732 
…mparison needed

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 update remaining version identifiers to 4.0
400c5c8 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue Feb 6, 2023
@planetf1
Merge pull request #7400 from planetf1/gradle23
1302a95 
#7330 Additional gradle updates post-migration
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 stop on any gradle deprecation warnings to prevent accident…
e5cf9f0 
…al usage regressions

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 remove spotbugs config - no longer used
f766037 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit to planetf1/egeria that referenced this issue Feb 6, 2023
@planetf1
odpi#7330 remove additional files no longer matching build pipelines
1a88686 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue Feb 6, 2023
@planetf1
Merge pull request #7402 from planetf1/gradle23
f569260 
#7330 stop on use of deprecated gradle features & remove files not needed
@planetf1 planetf1 mentioned this issue Feb 7, 2023
Closed
@planetf1
Copy link
Member Author

planetf1 commented Feb 7, 2023

See #689 for docs updates

@planetf1 planetf1 changed the title Version 4 - switch dev over Version 4 - switch dev over (POM removal remains) Feb 7, 2023
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 Additional updates to workflows for v4 switchover
327de19 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 updates to gradle properties
9a9b4f1 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 fix dup glossary-author-fvt artifact reference in settings.…
fbbb3ee 
…gradle

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 Disable caching for codeQL workflow as full before/after co…
0e0e7ae 
…mparison needed

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 update remaining version identifiers to 4.0
b1a2b24 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 stop on any gradle deprecation warnings to prevent accident…
2b81cf3 
…al usage regressions

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 remove spotbugs config - no longer used
89958f0 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Feb 28, 2023
@planetf1 @bogdan-sava
odpi#7330 remove additional files no longer matching build pipelines
fa49f07 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 mentioned this issue Mar 19, 2023
Merged
planetf1 added a commit to planetf1/egeria that referenced this issue Mar 21, 2023
@planetf1
Do odpi#7330 remove maven poms
aa5eace 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit to planetf1/egeria that referenced this issue Mar 21, 2023
@planetf1
odpi#7330 remove additional poms after main merge
354dffa 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1
Copy link
Member Author

complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planetf1 planetf1

Labels
None yet
Projects
No open projects
Egeria V4.0 Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@planetf1