feat: upgrade OTEL #808
Open
feat: upgrade OTEL #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2024
srisuman
approved these changes
Sep 5, 2024
zepatrik
approved these changes
Sep 9, 2024
|
In the past, opentelemetry regularly introduces backwards-incompatible changes to their SDKs in minor releases. Have you checked if Hydra+Keto+Kratos+Oathkeeper work with this new version? |
|
@alnr I have tested with Fosite's unit tests and haven't seen any issues. I have not tried this with Hydra or the other products. I don't have those running locally. |
|
@alnr Can this move forward? I have tested this with Fosite and it works. |
|
I don't have capacity right now to verify this doesn't cause upgrade issues in kratos/keto/hydra/oathkeeper. |
|
Interestingly, Hydra is already at v1.28 - https://github.com/ory/hydra/blob/master/go.mod#L60C2-L63C40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the request made in ory/fosite#809, this PR proposes upgrading the OTEL modules to the latest version (v1.29.0).
Related Issue or Design Document
ory/fosite#809
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
N/A