Add Nutanix failure domain documentation #8555
Conversation
|
Hi @yannickstruyf3. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d8660091 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ### failureDomains[0].cluster.type (required) | ||
| Type to identify the failure domain Prism Element cluster. (Permitted values: `name` or `uuid`) | ||
|
|
||
| ### failureDomains[0].cluster.name (`name` or `UUID` required) |
There was a problem hiding this comment.
Do you mean: "failureDomains[0].cluster.name or failureDomains[0].cluster.uuid required"? Someone might think you mean this value could be set to name or UUID. It looks like this could only be set to name. Same question with other objects below that say: "(name or UUID required)". There are eight such objects here.
There was a problem hiding this comment.
Thanks for the feedback @chrisnegus.
For the cluster object in a failure domain the name or the uuid are required. What would your guidance be to make this more clear? For example should we use the full path: "failureDomains[0].cluster.name or failureDomains[0].cluster.UUID required"?
There was a problem hiding this comment.
Yeah, maybe. My first impression was that failureDomains[0].cluster.type could be set to a name or a UUID, which I don't believe is the case here. So being explicit might be good.
There was a problem hiding this comment.
I have updated the documentation to use the full paths of the spec attributes. Please take a look.
582e688
to
2aedfa6
Compare
|
/ok-to-test |
|
Can you update the hash here with |
2aedfa6
to
e0f01dd
Compare
|
Corrected the link. Presubmit passed now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
=======================================
Coverage 72.40% 72.40%
=======================================
Files 578 578
Lines 45373 45373
=======================================
Hits 32853 32853
Misses 10790 10790
Partials 1730 1730 ☔ View full report in Codecov by Sentry. |
Issue #, if available:
N/A
Description of changes:
Update Nutanix documentation to include failure domain example.
Testing (if applicable):
N/A
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.