Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open fewer files at once during migration. #2342

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

nataliecarey
Copy link
Contributor

This is intended to resolve an issue I was facing with a migration yesterday where there was a "too many files open" error for a large prototype. I'd expect this to be more reliable too as it's less likely to choke slower systems up.

Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change requested and I'll approve

@@ -0,0 +1,64 @@
const { asyncSeriesMap } = require('./asyncSeriesMap')
describe('asyncSerialMap', () => {
const nextTick = ms => new Promise((resolve) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why ms is a parameter here if it's not used in the function. Perhaps replace ms with ()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it used to be a wait function before I realised it could be nextTick. I'll remove it.

Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nataliecarey nataliecarey merged commit cdcf353 into main Sep 19, 2023
27 checks passed
@nataliecarey nataliecarey deleted the open-fewer-files-concurrently branch September 19, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants