[SPARK-46055][SQL][FOLLOWUP] Respect code style for scala. #44079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ccf76
to
4b0b930
Compare
|
ping @heyihong cc @cloud-fan |
cloud-fan
reviewed
Nov 29, 2023
| @@ -503,7 +503,7 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { | |||
| */ | |||
| override def databaseExists(dbName: String): Boolean = { | |||
| try { | |||
| getDatabase(dbName) | |||
| makeDatabase(None, dbName: String) | |||
There was a problem hiding this comment.
why do we make it more verbose here?
There was a problem hiding this comment.
Reduce the stack depth.
There was a problem hiding this comment.
the readability will become worse ... I like it the way it was originally
4b0b930
to
88aaff5
Compare
cloud-fan
reviewed
Nov 30, 2023
| @@ -503,7 +503,7 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { | |||
| */ | |||
| override def databaseExists(dbName: String): Boolean = { | |||
| try { | |||
| getDatabase(dbName) | |||
| makeDatabase(None, dbName) | |||
There was a problem hiding this comment.
I disagree with this change. There is nearly no benefit and it's kind of encouraging people to never use parameter default values but just call the base function with all parameter values specified.
There was a problem hiding this comment.
SGTM. Let's revert it.
88aaff5
to
10fee00
Compare
| fetchMetadata: Boolean): ResolvedNamespace = { | ||
| catalog: CatalogPlugin, | ||
| ns: Seq[String], | ||
| fetchMetadata: Boolean): ResolvedNamespace = { |
There was a problem hiding this comment.
Is this the only indentation issue in this file, @beliefer ?
dongjoon-hyun
approved these changes
Dec 1, 2023
|
Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
### What changes were proposed in this pull request? apache#43959 get metadata when resolving catalogs instead of directly calling catalog. This PR fix one minor issues that some code didn't follow the code style of scala. ### Why are the changes needed? Respect code style for scala. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? Exists test cases. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#44079 from beliefer/SPARK-46055_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Jiaan Geng <beliefer@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#43959 get metadata when resolving catalogs instead of directly calling catalog.
This PR fix one minor issues that some code didn't follow the code style of scala.
Why are the changes needed?
Respect code style for scala.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Exists test cases.
Was this patch authored or co-authored using generative AI tooling?
'No'.