[PM-14425] [BEEEP] Add test plans #1106
Open
+245
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck in BitwardenTestCase for skip simulator checking.
… unit test plans so they are empty on remote and only generated locally each time if needed.
|
No New Or Fixed Issues Found |
Co-authored-by: Katherine Bertelsen <kbertelsen@bitwarden.com>
fedemkr
commented
Nov 15, 2024
| TEST_PLAN_SNAPSHOT_PATH="TestPlans/TestPlan-Snapshot.xctestplan" | ||
| SNAPSHOT_TESTS_TARGET="BitwardenSharedTests" | ||
|
|
||
| mint install atakankarsli/xctestplanner@v1.0.9 |
There was a problem hiding this comment.
I've decided not to include the installation of xctestplanner in the Mintfile so it's only installed when actually being used. For now this script won't be called in CI/CD so there's no need to waste time installing xctestplanner .
There was a problem hiding this comment.
This is cool!
A few questions from me:
- I'm seeing a few date/time failures in the tests. It looks like we previously set
TZ=UTCas an environment variable. Could you add that to the test plans? - We used to have a splash screen that showed while testing. That relies on a
-testingargument passed on launch, could you add that? - Should your comment for
git update-index --skip-worktree TestPlans/TestPlan-Snapshot.xctestplan TestPlans/TestPlan-Unit.xctestplanbe documented in the README?
Previous test settings:
It looks like the test plans don't include the Networking target, could you include that? I think that's why the test counts are different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14425
📔 Objective
Add test plans so we can separate unit vs snapshot tests vs all tests.
Note:
Before the
generate_test_plans.shis used, make sure to run the next command on the root folder so the changes in the test plans are not tracked by git so the test plans changes remain locally. Therefore there is less possibility of merge conflicts and there's no need to keep the files updated remotely as they can be automatically generated.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes