Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: os/bluestore: Make truncate() drop unused allocations #60237

Open
wants to merge 2 commits into
base: reef
Choose a base branch
from
Open

reef: os/bluestore: Make truncate() drop unused allocations #60237

wants to merge 2 commits into from

Conversation

aclamk
Copy link
Contributor

@aclamk aclamk commented Oct 10, 2024 •
edited
Loading

Now when truncate() drops unused allocations.
Modified Close() in BlueRocksEnv to unconditionally call truncate.

Fixes: https://tracker.ceph.com/issues/68488

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

aclamk and others added 2 commits October 10, 2024 09:04
@aclamk
os/bluestore: Make truncate() drop unused allocations
a3e270c 
Now when truncate() drops unused allocations.
Modified Close() in BlueRocksEnv to unconditionally call truncate.

Fixes: https://tracker.ceph.com/issues/68488

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 9fc65f1)

Conflicts:
	src/os/bluestore/BlueFS.cc, trivial
@ifed01 @aclamk
test/store_test: get rid off explicit offset specifications in shared
94f7243 
blob repair test case.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 482e5b8)
@aclamk aclamk requested a review from a team as a code owner October 10, 2024 09:12
@github-actions github-actions bot added this to the reef milestone Oct 10, 2024
@aclamk
Copy link
Contributor Author

aclamk commented Oct 10, 2024

jenkins test make check

@aclamk aclamk requested a review from ifed01 October 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifed01 ifed01 Awaiting requested review from ifed01

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bluestore core tests
Projects
None yet
Milestone
reef
Development

Successfully merging this pull request may close these issues.
2 participants
@aclamk @ifed01