Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(volo): make sure hotrestart sockdir exists #517

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(volo): make sure hotrestart sockdir exists #517

merged 1 commit into from
Nov 4, 2024

Conversation

Millione
Copy link
Member

@Millione Millione commented Nov 4, 2024

Motivation

Prior to this, the hotrestart sockdir must be ensured to exist by the user, otherwise the initialization will fail.

Solution

This PR fixes it by checking and creating the sockdir in volo itself.

@Millione Millione requested review from a team as code owners November 4, 2024 03:19
@Millione Millione enabled auto-merge (squash) November 4, 2024 03:58
@Millione Millione merged commit e9ab2fd into cloudwego:main Nov 4, 2024
15 checks passed
@Millione Millione deleted the hotrestart-path branch November 4, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Millione @PureWhiteWu