Update SiftGPU to use floorf for floats #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest MSVC update the build breaks on Windows with this error:
`error: calling a __host__ function("__floorf") from a __global__ function(...) is not allowed`
This happens due to the use of `floor` reverting to a host function for float arguments, whereas the correct usage of `floorf` is calling a device function.
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
With the latest MSVC update the build breaks on Windows with this error:
`error: calling a __host__ function("__floorf") from a __global__ function(...) is not allowed`
This happens due to the use of `floor` reverting to a host function for float arguments, whereas the correct usage of `floorf` is calling a device function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest MSVC update the build breaks on Windows with this error:
error: calling a __host__ function("__floorf") from a __global__ function(...) is not allowedThis happens due to the use of
floorreverting to a host function for float arguments, whereas the correct usage offloorfis calling a device function.