Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Qt in COLMAPConfig only if GUI is enabled #1365

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

sarlinpe
Copy link
Contributor

@sarlinpe sarlinpe commented Jan 2, 2022

PR #1165 introduced the CMake option GUI_ENABLED to disable to GUI but did not disable the Qt requirement in the exported COLMAPConfig.cmake file.

@ahojnnes
Copy link
Contributor

ahojnnes commented Jan 2, 2022

Great, thanks Paul!

@ahojnnes ahojnnes enabled auto-merge (squash) January 2, 2022 10:34
@ahojnnes ahojnnes merged commit 9db82a8 into colmap:dev Jan 2, 2022
lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
@sarlinpe sarlinpe deleted the fix-cmakeconfig branch February 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants