Remove check on Qt version #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you stuck with 18.04? I was planning to not support 18.04 going forward, as its outdated default compiler/packages hold development back due to lack of C++14, etc. |
|
Nope I indeed need to update very soon... But I don't think that this issue is specific to Ubuntu 18.04. |
|
I would rather add the 5.9.5 version explicitly, as it does appear to be fixed for the Qt version under 20.04 and 22.04. It sounds a little dangerous to mess with the default flags across all versions. |
|
Looked at the cmake bug again and also the special casing here. I think we can go ahead as proposed by you. Apologies , didn't have time to look with necessary detail yesterday. Thanks. |
auto-merge was automatically disabled
July 11, 2023 07:33
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on Ubuntu 18.04 and seeing the extra
-fPICflag added by Qt 5.9.5, as reported in #1753 #1813. Upgrading to cmake 3.26 does not help. I think that it's safer to remove the flag regardless of the Qt version.