Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with the convention of ceres doc on SqrtInformation. #2611

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

B1ueber2y
Copy link
Contributor

@B1ueber2y B1ueber2y commented Jun 21, 2024

[Minor] Align with the S_{-1/2}f(x) in the ceres doc here http://ceres-solver.org/nnls_covariance.html. Move .transpose() into the SqrtInformation matrix.

@ahojnnes ahojnnes enabled auto-merge (squash) June 21, 2024 20:52
@ahojnnes ahojnnes merged commit 51dc609 into colmap:main Jun 21, 2024
15 checks passed
@B1ueber2y B1ueber2y deleted the fix/sqrtinformation_convention branch June 21, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants