feat: EXC-1750: Charge canisters proportionally to their load #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change applies charges for each fully executed canister. The total amount of points charged is evenly distributed across canisters, but it is not included in the compute capacity used to calculate long/new execution cores.
This change applies charges for executed canisters proportionally to their actual load (number of executed instructions). This should prioritize interactive canisters vs batch canisters.
d1ebfb4
to
80b563e
Compare
|
Nit: Is "charge" in title and description the appropriate term for this? I'd perhaps rephrase to make sure it's clear this is about scheduling priority and not actual "cost". |
There was a problem hiding this comment.
Maybe not very important, but what I'm somehow missing is a more "end-to-end" test that's capturing what happens on a let's say realistic workload with many canisters, some heavy and some lightweight so that we understand how much different the behavior is now vs. before the change.
Base automatically changed from
andriy/exc-1735-charge-full-executions
to
master
October 2, 2024 21:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies charges for executed canisters proportionally to their actual load (number of executed instructions).
This should prioritize interactive canisters vs batch canisters.