Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Histogram library. #1828

Merged
merged 4 commits into from
Oct 21, 2024
Merged

feat: Histogram library. #1828

merged 4 commits into from
Oct 21, 2024

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Oct 3, 2024 •
edited
Loading

This will be used to track instructions consumed to service a method call, but it could be used to track any kind of distribution. E.g. request size, response size, latency, etc.

Next PR 👉

@github-actions github-actions bot added the feat label Oct 3, 2024
@daniel-wong-dfinity-org daniel-wong-dfinity-org mentioned this pull request Oct 3, 2024
Merged
@daniel-wong-dfinity-org daniel-wong-dfinity-org mentioned this pull request Oct 4, 2024
Draft
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review October 4, 2024 18:45
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner October 4, 2024 18:45
aterga
aterga requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@aterga aterga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. The biggest questions from my side are:

  • Why not [l, r) intervals?
  • Why not use unassigned ints for the values?
  • Why suggest these exact buckets (STANDARD_POSITIVE_BIN_INCLUSIVE_UPPER_BOUNDS)?

rs/nervous_system/histogram/src/lib.rs Outdated Show resolved Hide resolved
rs/nervous_system/histogram/src/lib.rs Outdated Show resolved Hide resolved
rs/nervous_system/histogram/src/lib.rs Outdated Show resolved Hide resolved
rs/nervous_system/histogram/src/lib.rs Show resolved Hide resolved
rs/nervous_system/histogram/src/lib.rs Show resolved Hide resolved
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit 4cd4225 Oct 21, 2024
25 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the histogram-daniel-wong branch October 21, 2024 15:10
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2024
@daniel-wong-dfinity-org
feat: Instruction stats library. (#1829)
3f3b6aa 
In the next PR, this is used to come up with an enhanced `#[update]`
attribute.

[👈 Previous PR] | [Next PR 👉]

[👈 Previous PR]: #1828
[Next PR 👉]: #1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alin-at-dfinity alin-at-dfinity alin-at-dfinity left review comments

@aterga aterga aterga approved these changes

Assignees
No one assigned
Labels
feat @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-wong-dfinity-org @aterga @alin-at-dfinity