Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [MR-552] Trigger callback expiration in StateMachine #1832

Merged
merged 51 commits into from
Oct 4, 2024

Conversation

alin-at-dfinity
Copy link
Contributor

At the top of every DSM round, right after message expiration, trigger the expiration of best-effort callbacks.

…lbacks_with_enqueued_response invariant in CanisterQueues doc comment.
…ry reject response that will result in a critical eror anyway (and the response being dropped).
Assign type parameters to canister queues and references, to designate them as either input/inbound or output/outbound.

Ensures that input queues can only hold inbound references; and output queues can only hold outbound references. Implements separate logic (for inbound and outbound references) for determining staleness, lookup and removal.
… the two specific `MessageStore<_>` implementations into `MessageStoreImpl`.
…(but still CanisterInput by value for input queues).
…d to InboundReference / OutboundReference, to make it clear that the functions may panic (even though the two types are essentially private to the module).
Copy link
Contributor

@derlerd-dfinity derlerd-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Did a first pass and left some comments.

rs/messaging/src/state_machine.rs Show resolved Hide resolved
rs/replicated_state/src/replicated_state.rs Outdated Show resolved Hide resolved
rs/replicated_state/tests/system_state.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@derlerd-dfinity derlerd-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Mostly looks good to me. Left some comments/questions.

rs/messaging/src/state_machine.rs Show resolved Hide resolved
rs/replicated_state/tests/system_state.rs Show resolved Hide resolved
Copy link
Member

@oggy-dfin oggy-dfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. a couple of nits.

rs/replicated_state/src/replicated_state.rs Show resolved Hide resolved
rs/replicated_state/src/replicated_state.rs Outdated Show resolved Hide resolved
…s a list of errors, one for every response that could not be enqueued.
Base automatically changed from alin/MR-552-callback-expiration to master October 4, 2024 17:04
@alin-at-dfinity alin-at-dfinity requested a review from a team as a code owner October 4, 2024 17:04
@alin-at-dfinity alin-at-dfinity added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@alin-at-dfinity alin-at-dfinity added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit 8105c71 Oct 4, 2024
24 checks passed
@alin-at-dfinity alin-at-dfinity deleted the alin/MR-552-enable-callback-expiration branch October 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants