-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [MR-552] Trigger callback expiration in StateMachine
#1832
feat: [MR-552] Trigger callback expiration in StateMachine
#1832
Conversation
…eadlineExpired and ResponseDropped.
…ed-inbound-responses
…ed-inbound-responses
…lbacks_with_enqueued_response invariant in CanisterQueues doc comment.
…ed-inbound-responses
…ry reject response that will result in a critical eror anyway (and the response being dropped).
… as a dummy canister ID.
Assign type parameters to canister queues and references, to designate them as either input/inbound or output/outbound. Ensures that input queues can only hold inbound references; and output queues can only hold outbound references. Implements separate logic (for inbound and outbound references) for determining staleness, lookup and removal.
… the two specific `MessageStore<_>` implementations into `MessageStoreImpl`.
…nt when decoding CanisterQueue from proto.
…(but still CanisterInput by value for input queues).
…d to InboundReference / OutboundReference, to make it clear that the functions may panic (even though the two types are essentially private to the module).
At the top of every DSM round, right after message expiration, trigger the expiration of best-effort callbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Did a first pass and left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Mostly looks good to me. Left some comments/questions.
…xpired_input() in all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. a couple of nits.
…s a list of errors, one for every response that could not be enqueued.
At the top of every DSM round, right after message expiration, trigger the expiration of best-effort callbacks.