-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Onramper integration [GIX-2854] #2560
Merged
AntonioVentilii-DFINITY
merged 15 commits into
main
from
feat(frontend)/onramper-integration
Oct 4, 2024
Merged
feat(frontend): Onramper integration [GIX-2854] #2560
AntonioVentilii-DFINITY
merged 15 commits into
main
from
feat(frontend)/onramper-integration
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…854] (#2488) # Motivation We create an util to generate the source link to provide to the Onramper widget, given a set of parameters. Documentation can be found [here](https://docs.onramper.com/docs/supported-widget-parameters). For now we define a small set of FIAT currencies, just for the scope of testing. The list can be expanded or improved after. # Changes - Create ENV variables for Onramper API keys. - Add types for params of the new util. - Create utils to build the source code and concatenate all params into a single string. - Create tests. # Tests Create some tests to verify the correct widget link: the links were manually tested in the [Onramper sandbox](https://docs.onramper.com/docs/customise-the-ux) and simply opening them in the browser with the test API key.
…4] (#2510) # Motivation We would prefer to have a clear indication that Onramper is in DEV mode when an user clicks on the Buy button: we adapt the modal title based on the ENV.
# Motivation We include the Onramper widget among our components and in the buy modal. # Changes - Create util to transform a `wallet` object into an acceptable wallet input for Onramper (and test). - Create OnramperWidget component: - Default crypto is (in mutually excluding order): - the token in which transaction page the user is - the native token of the selected network, if any (e.g. IC selected is ICP, Ethereum selected is ETH) - ICP token - The only cryptos enabled are the ones that have a correspondent Onramper ID coded (same goes for networks) # Tests ### Desktop https://github.com/user-attachments/assets/92b10d4b-0a04-473d-8ac2-d8f82f2bab69 ### Mobile https://github.com/user-attachments/assets/e9df38d0-0603-4f79-8fa2-76cf7dce1b1b
peterpeterparker
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Confirmed offline: This PR is the sum ups of PRs that have been reviewed separatly.
AntonioVentilii-DFINITY
deleted the
feat(frontend)/onramper-integration
branch
October 4, 2024 13:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed offline, we merge this PR providing only the feature of buying tokens, without feedback on pending transactions to the user. That will come in a second moment.
Note: we remove the feature-flag for OnRamper