feat(frontend): Add btc pending transactions store #2635
Conversation
|
@AntonioVentilii-DFINITY @peterpeterparker please review |
| type Address = string; | ||
| type BtcPendingTransactionsStoreData = Record<Address, Array<PendingTransaction>>; | ||
|
|
||
| interface BtcPendingTransactionsStore extends Readable<BtcPendingTransactionsStoreData> { |
There was a problem hiding this comment.
Should the data hold in the store contains the information if those are certified or not? extending for example CertifiedData and CertifiedStore
There was a problem hiding this comment.
It will always be certified. This endpoint can't be called with a query. The endpoint also prunes outdated pending transactions.
This way I didn't need to implement a background tasks updating them.
I added a comment because it's not obvious. Good point.
There was a problem hiding this comment.
Instead of a comment, what do you think of using the CertifiedData type, excluding certified and replacing it with certified: false as type. That way even code wise it's specified that it's always certified?
There was a problem hiding this comment.
Do you mean setting certified: true always?
Sure I can do that as well.
There was a problem hiding this comment.
Do you mean setting certified: true always?
Yes sorry, stupid typo.
There was a problem hiding this comment.
Cool. So what I meant is also the following:
type AlwaysCertifiedData<T> = Omit<CertifiedData<T>, "certified"> & {certified: true};
type BtcPendingTransactionsStoreData = Record<Address, AlwaysCertifiedData<Array<PendingTransaction>>>;
Maybe AlwaysCertifiedData can even find place in the same module as CertifiedData?
There was a problem hiding this comment.
Ah, sorry, for the confusion. Done!
There was a problem hiding this comment.
I mean, my bad, I started with a typo ;)
d26ae17
to
d0f11b8
Compare
|
@peterpeterparker ready for another review |
1 similar comment
|
@peterpeterparker ready for another review |
7c8d384
to
4ba99a9
Compare
4ba99a9
to
8d8d366
Compare
Motivation
We will disable sending BTC tokens while the user has pending transaction. Pending transactions will come from Oisy backend.
In this PR, I created a store to save the pending transactions per address.
Changes
pendingTransactionsStore.Tests