fix(frontend): background was not hiding overflow [GIX-3067] #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterpeterparker for now yes, but we are going to change the background soon enough (in that case it will not be an issue to have it stick to top-left, according to design) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After PR #2621 , there is an error in the background. Since the big background is used for smaller screen, there is no overflow control and the screen ends up being larger and longer.
To solve it we wrap the background in a container that will manage the overflow (and the general position), while the background image keeps its dimensions.
Before
Screen.Recording.2024-10-03.at.21.47.37.mov
After
Screen.Recording.2024-10-03.at.21.46.41.mov