Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): remove error constructor #2643

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Overriding the constructor in CanisterInternalError is not needed given that it overrides the default with the same declaration.

Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@peterpeterparker peterpeterparker enabled auto-merge (squash) October 4, 2024 07:04
@peterpeterparker peterpeterparker merged commit f52ef1b into main Oct 4, 2024
9 checks passed
@peterpeterparker peterpeterparker deleted the chore/error-contructor branch October 4, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants