Make AxHost work without classic COM interop. #10927
Conversation
|
@JeremyKuhne if this overlaps with whatever else you guys have in the pipeline for COM interop in .NET 9 feel free to delay it, but it would be nice to get this fix into the release, if possible. Considering that we'll probably want unit test coverage that means we (probably) want to get the other PR in first. If you need the scratch project thats based on both this PR and the other PR I can look into putting up a third branch that includes both PRs but for now I haven't bothered pushing it, would be more easy once the other PR is merged eventually. Note that testing with |
|
@weltkante We definitely plan to get this done for .NET 9. |
| } | ||
| else | ||
| { | ||
| Marshal.ReleaseComObject(_instance); |
There was a problem hiding this comment.
This throws if ComHelpers.BuiltInComSupported is false but I believe it was a no-op for ComObject anyways, at least used to be. I'm not clear if it is possible to do manual disposal of a ComObject based RCW so maybe this just needs to be a no-op for this case.
Fixes #10583
Proposed changes
<BuiltInComInteropSupport>false</BuiltInComInteropSupport>), which is a requirement for AOT.Customer Impact
Regression?
Risk
Before
<BuiltInComInteropSupport>false</BuiltInComInteropSupport>in the project file.After
<BuiltInComInteropSupport>false</BuiltInComInteropSupport>in the project file.Test methodology
Test environment(s)
<BuiltInComInteropSupport>false</BuiltInComInteropSupport>in the project file[assembly: DisableRuntimeMarshalling]in my test, in case its relevantMicrosoft Reviewers: Open in CodeFlow