Skip test "TextBoxBase_Undo_CanUndo_Success" and "TextBoxBase_Copy_PasteNotEmpty_Success" #11562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…steNotEmpty_Success"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11562 +/- ##
===================================================
- Coverage 74.48439% 74.40698% -0.07742%
===================================================
Files 3039 3039
Lines 629066 629066
Branches 46834 46834
===================================================
- Hits 468556 468069 -487
- Misses 157154 157651 +497
+ Partials 3356 3346 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Jun 22, 2024
|
What is the plan with all the tests that use shared resources like Clipboard? Just skip them, I still believe there is a Xuint solution without putting them all in one file or class but if that’s required by the repo it’s a better solution then skipping them all. Sent from my iPhoneI apologize for any typos Siri might have made.(503) 803-6077On Jun 24, 2024, at 2:03 AM, Leaf Shi ***@***.***> wrote:
@LeafShi1 commented on this pull request.
In src/System.Windows.Forms/tests/UnitTests/TextBoxBaseTests.cs:
[WinFormsFact]
+ [SkipOnArchitecture(TestArchitectures.X86,
+ "Flaky tests, see: #11558")]
public void TextBoxBase_Copy_PasteNotEmpty_Success()
I will do this in next PR
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #11559, #11558
Proposed changes
Microsoft Reviewers: Open in CodeFlow