Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset support #19

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Unset support #19

merged 1 commit into from
Sep 1, 2019

Conversation

greut
Copy link
Member

@greut greut commented Aug 29, 2019

Passing more tests don't mean that the features are correct, but it's a starting point.

before

100% tests passed, 0 tests failed out of 172

now

100% tests passed, 0 tests failed out of 179

Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@greut greut mentioned this pull request Aug 30, 2019
@andreynering
Copy link
Contributor

Hi @greut, thanks for this PR!

Since you seem to have more interest in the project than me, you would accept having write access to this repo to more actively help maintain it? (Feel free to say "no" if you don't feel like it).

Keep in mind I'm not an official Editorconfig member, so this is not an official invite. /ccing @10sr for opinions on this.

@andreynering andreynering merged commit 9f2e0a7 into editorconfig:master Sep 1, 2019
@greut greut deleted the unset branch September 2, 2019 05:34
@greut
Copy link
Member Author

greut commented Sep 2, 2019

That'd be much appreciated. Cheers,

@10sr
Copy link
Member

10sr commented Sep 2, 2019

Sounds awesome to me!

@xuhdev @treyhunner What do you think of inviting @greut to editorconfig org? He has recently contributed some important work (#14 #15 #18 #19) for core-go to pass many of the test.

@xuhdev
Copy link
Member

xuhdev commented Sep 2, 2019

Sure, invited! @greut Thanks and welcome!

@mstruebing
Copy link
Contributor

Congrats @greut :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants