Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved code to src/ and added docker info. #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micheas
Copy link

@micheas micheas commented Jul 1, 2017

This is a first pass, and any comments would be appreciated.

This is mostly a code reorganization to simplify building the
docker image.

It allows the initial groups/clusters to be set via environment variables
using the following format:

export MEMCACHED_GROUPS=2
export MEMCACHED_GROUP_0_NAME=docker
export MEMCACHED_GROUP_0_HOST_COUNT=1
export MEMCACHED_GROUP_0_HOST_0=memcached
export MEMCACHED_GROUP_0_PORT_0=11211
export MEMCACHED_GROUP_1_NAME=cluster
export MEMCACHED_GROUP_1_HOST_COUNT=2
export MEMCACHED_GROUP_1_HOST_0=memcached01.example.com
export MEMCACHED_GROUP_1_PORT_0=11211
export MEMCACHED_GROUP_1_HOST_1=memcached02.example.com
export MEMCACHED_GROUP_1_PORT_1=11211

The docker-compose.yml file is another example of how to optionally
pass in default values.

It also has a small fix for xss checking in src/Library/Bootstrap.php
that recursively checks values that are passed in as an array instead
of skipping them.

This is a first pass to make it easy for developers to get this up
and running on their local machines without needing to know too
much about how to set up a php application, and easy for there to be
a set of default configs that "just work" without needing to burn a new
docker image.

This is mostly a code reorganization to simplify building the
docker image.

It also has a small fix for xss checking in src/Library/Bootstrap.php
that recursively checks values that are passed in as an array instead
of skipping them.

This is a first pass to make it easy for developers to get this up
and running on their local machines without needing to know too
much about how to set up a php application.
@cfoellmann
Copy link
Contributor

maybe you can rename this to WIP: Add Docker support or something? The WIP indicating it is not ready for testing yet

@micheas
Copy link
Author

micheas commented Feb 9, 2019

Devs at a previous employer were using it without issue while I was there without issue.

I’ll look at it and see, but my memory is that it was working fine. Changes at this point would be style issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants