Set a timeout value for the AmazonS3Client #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch on the SDK, these calls need to timeout. I'm worried that 10 seconds will be too low for someone running this from a slow network. When running within the same AWS region 10 seconds should be more than enough. Let's try to find a balance on this. How about setting it to 100 (similar to .NET desktop) and/or making the timeout a config value so it can be adjusted if needed? |
|
Thanks for the suggestion @emgarten ! I think it makes a lot of sense. I have enlarged the timeout to 100 seconds. |
|
Released in https://www.nuget.org/packages/Sleet/5.0.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this in the AWS S3 document https://docs.aws.amazon.com/sdk-for-net/v3/developer-guide/retries-timeouts.html:
So the AWS SDK will set the largest integer as the timeout by default. Currently, we will always wait for the response to come, which will make the SDK API unresponsive and decrease the efficiency. Even worse, if the response is lost during its delivery, we will wait there forever. In this regard, I manually set the timeout of AmazonS3Client as 10 seconds.