-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Fix emacs compiler warnings (#4451) #4542
Conversation
Do not depend on cl. Assume presence of before-save-hook (Emacs 22) and remove erlang-check-module-name-init. Remove (run-hooks 'erlang-mode-hook) from erlang-mode definition because define-derived-mode does it already. Replace erlang-caddr with caddr from Emacs 26. erlang.el now compiles cleanly in Emacs 24.5, 25, 26, 27.
The test case emacs_SUITE:compile_and_load still fails on emacs-27.1, not really your problem but you know much more about The same testcase fails on emacs-25.2 which it didn't before:
|
I looked at emacs_SUITE.erl and it seems this line might be problematic. Not sure if that's the culprit though.
I also found erldoc.el compiles with a warning under emacs 27. Is this what's causing the failure? Though the warning can be suppressed with the following simple change it might be a regression on emacs' side. I will check with emacs upstream to see what's happening to
|
You can run with Yes warnings are errors if emacs > 25 and I understand the testcase correct. And it fails on erldoc:
The other modules have warnings as well, but doesn't seem to fail the testcase, I have not had time to dig deeper yet. |
Thanks for the tip Somehow |
Thanks. |
Do not depend on cl. Assume presence of before-save-hook (Emacs 22)
and remove erlang-check-module-name-init. Remove (run-hooks
'erlang-mode-hook) from erlang-mode definition because
define-derived-mode does it already. Replace erlang-caddr with caddr
from Emacs 26.
erlang.el now compiles cleanly in Emacs 24.5, 25, 26, 27.