Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor leaks in erlang:trace/3 #4596

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

sverker
Copy link
Contributor

@sverker sverker commented Mar 9, 2021

Leaks a couple of words per erlang:trace/3 call if FlagList argument

  • has more than one {tracer, _} in list
  • has {tracer, _} followed by invalid option or improper list
  • has {tracer, _} in list but fails to seize code write permission

Never called with NULL pointers anyway.
@sverker sverker self-assigned this Mar 9, 2021
@sverker sverker added fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Mar 9, 2021
* if more than one {tracer, Pid} in list
* if {tracer, Pid} followed by invalid flag or improper list
* if {tracer, Pid} but failed to seize code write permission
@sverker sverker force-pushed the sverker/erts/tracer-opt-leaks branch from 11664e6 to 465cca7 Compare March 10, 2021 11:48
@sverker sverker merged commit 9f93bca into erlang:maint Mar 10, 2021
@sverker sverker deleted the sverker/erts/tracer-opt-leaks branch June 16, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants