Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erl_interface: support map term for ei_x_format* #7602

Merged
merged 1 commit into from
Sep 25, 2023
Merged

erl_interface: support map term for ei_x_format* #7602

merged 1 commit into from
Sep 25, 2023

Conversation

fregate
Copy link
Contributor

@fregate fregate commented Aug 30, 2023

Add support to encode map-term in ei_x_format(_wo_ver)

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

CT Test Results

    2 files    22 suites   7m 44s ⏱️
156 tests 153 ✔️ 3 💤 0 ❌
192 runs  189 ✔️ 3 💤 0 ❌

Results for commit 5c05c1e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@fregate fregate mentioned this pull request Aug 30, 2023
Closed
@fregate
Copy link
Contributor Author

fregate commented Aug 30, 2023

I don't understand what I have to do to sign CLA. Because I've already signed it. And I can't find what email is being used (only name shown). But it seems like my primary email in my repo.

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Sep 4, 2023
@sverker
Copy link
Contributor

sverker commented Sep 5, 2023

I added 4 new commits.

Have you "add(ed) the email address used for this commit to your account" as suggested above.

@fregate
Copy link
Contributor Author

fregate commented Sep 6, 2023 •
edited
Loading

I added 4 new commits.

Have you "add(ed) the email address used for this commit to your account" as suggested above.

I can't find what email used for commits. See my name only

@sverker
Copy link
Contributor

sverker commented Sep 6, 2023

I can't find what email used for commits. See my name only

You can use command git log --pretty=full in your repo to see both Author and Commiter of your commits:

Author: Anton Filippov <anton@filippov.im>
Commit: Anton Filippov <anton@filippov.im>

@sverker
Copy link
Contributor

sverker commented Sep 7, 2023

CLAassistant-bot now says "All committers have signed the CLA", so I guess all is good.

@fregate
Copy link
Contributor Author

fregate commented Sep 12, 2023 •
edited
Loading 

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
ei_connect_SUITE:ei_make_pid failed on line 283
Reason: {badmatch,{error,5}}
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

/buildroot/otp/lib/erl_interface/make_test_dir/erl_interface_test/ei_connect_SUITE_data/ei_connect_test: Unexpected end of file
Testing make_test_dir.erl_interface_test: *** FAILED test case 25 of 83 ***

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
ei_connect_SUITE:ei_link_unlink failed on line 331
Reason: {badmatch,{error,5}}
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

/buildroot/otp/lib/erl_interface/make_test_dir/erl_interface_test/ei_connect_SUITE_data/ei_connect_test: Unexpected end of file
Testing make_test_dir.erl_interface_test: *** FAILED test case 26 of 83 ***

Need to rerun tests. These tests are failed in some other reason, not in case of ei_format, I guess
Or I can't find relation to

Locally all tests are ok

Testing make_test_dir.erl_interface_test: Starting test, 83 test cases
=WARNING REPORT==== 13-Sep-2023::11:19:27.661597 ===
Process <0.441.0> on node 'test_server@hpw' enabled access to the emulator internal state.
NOTE: This is an erts internal test feature and should *only* be used by OTP test-suites.


ei_epmd_r4_port: Wed Sep 13 11:19:30 2023: -> PORT2_REQ alive=test_server ip=127.0.1.1
ei_epmd_r4_port: Wed Sep 13 11:19:30 2023: <- PORT2_RESP result=0 (ok)
ei_epmd_r4_port: Wed Sep 13 11:19:30 2023:    port=34591 ntype=77 proto=0 dist-high=6 dist-low=5
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT attempt to connect to test_server
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT connected to remote
recv_status: Wed Sep 13 11:19:30 2023: <- RECV_STATUS (sok)
recv_challenge: Wed Sep 13 11:19:30 2023: <- RECV_CHALLENGE (ok) node = test_server@hpw, flags = 132087741, challenge = -225392337
send_challenge_reply: Wed Sep 13 11:19:30 2023: -> SEND_CHALLENGE_REPLY (ok) challenge = 826763385, digest = 72f43763db1b4a861f72fb13c83556b9
recv_challenge_ack: Wed Sep 13 11:19:30 2023: <- RECV_CHALLENGE_ACK (ok) digest = e35a7bde312607737a9c0b1e1e9c56d5
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT (ok) remote = test_server
-> REG_SEND From: #Pid<c42@hpw.0.0.14745600> To: rex
   {#Pid<c42@hpw.0.0.14745600>, {call, ei_connect_SUITE, rpc_test, ["!edalg ud jeH"], user}}
<- SEND To: #Pid<c42@hpw.0.0.14745600>
   {rex, "Hej du glade!"}
ei_epmd_r4_port: Wed Sep 13 11:19:30 2023: -> PORT2_REQ alive=test_server ip=127.0.1.1
ei_epmd_r4_port: Wed Sep 13 11:19:30 2023: <- PORT2_RESP result=0 (ok)
ei_epmd_r4_port: Wed Sep 13 11:19:30 2023:    port=34591 ntype=77 proto=0 dist-high=6 dist-low=5
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT attempt to connect to test_server
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT connected to remote
recv_status: Wed Sep 13 11:19:30 2023: <- RECV_STATUS (sok)
recv_challenge: Wed Sep 13 11:19:30 2023: <- RECV_CHALLENGE (ok) node = test_server@hpw, flags = 132087741, challenge = -772553716
send_challenge_reply: Wed Sep 13 11:19:30 2023: -> SEND_CHALLENGE_REPLY (ok) challenge = 1875056856, digest = 7270dcff80900fbebb021ff5c2288391
recv_challenge_ack: Wed Sep 13 11:19:30 2023: <- RECV_CHALLENGE_ACK (ok) digest = bdc85495db9bda036bf994acb0839afc
ei_xconnect: Wed Sep 13 11:19:30 2023: -> CONNECT (ok) remote = test_server
-> REG_SEND From: #Pid<c42@hpw.0.0.14745600> To: rex
   {#Pid<c42@hpw.0.0.14745600>, {call, ei_connect_SUITE, rpc_test, ["!edalg ud jeH"], user}}
<- SEND To: #Pid<c42@hpw.0.0.14745600>
   {rex, "Hej du glade!"}
Testing make_test_dir.erl_interface_test: *** SKIPPED test case 65 of 83 ***
Testing make_test_dir.erl_interface_test: TEST COMPLETE, 82 ok, 0 failed, 1 skipped of 83 test cases

Updating ../otp/lib/erl_interface/make_test_dir/ct_logs/index.html ... done
Updating ../otp/lib/erl_interface/make_test_dir/ct_logs/all_runs.html ... done


======================================================================

The test(s) ran successfully (ct_run returned a success code)
Test logs: ../otp/lib/erl_interface/make_test_dir/ct_logs/index.html

======================================================================
make[1]: Leaving directory ../otp/lib/erl_interface'

@sverker
Copy link
Contributor

sverker commented Sep 18, 2023

ei_connect_SUITE:ei_make_pid failed on line 283
Reason: {badmatch,{error,5}}

Those failed test case do not seem to be caused by this PR.
I've squashed all into one commit and rebased on a newer maint.

@fregate @sverker
Add support for map terms in ei_x_format(_wo_ver)
5c05c1e 
Co-authored-by: Sverker Eriksson <sverker@erlang.org>
@sverker sverker added feature testing currently being tested, tag is used by OTP internal CI labels Sep 21, 2023
@sverker sverker mentioned this pull request Sep 25, 2023
Open
@sverker sverker merged commit 0904204 into erlang:maint Sep 25, 2023
14 of 15 checks passed
@sverker
Copy link
Contributor

sverker commented Sep 25, 2023

Merged to maint for 26.2.

@sverker sverker added this to the OTP-26.2 milestone Sep 25, 2023
@fregate fregate deleted the eiformat-map-term-7598 branch September 26, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverker sverker sverker left review comments

Assignees

@sverker sverker

Labels
feature team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
OTP-26.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fregate @CLAassistant @sverker @rickard-green