Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code instead of tt #7695

Merged
merged 1 commit into from
Oct 11, 2023
Merged

code instead of tt #7695

merged 1 commit into from
Oct 11, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Following #7643, this removes all remains of (deprecated HTML element) tt from Erlang/OTP.

I'm opening it as a draft to signal I'll later rebase this on top of maint, since it contains changes from the aforementioned PR: I just wanna make sure CI passes and there's no obvious issues.

Also:

  • I ran make xmllint and saw no issues (there's lots of warnings but eventually it exits with 0)
  • I ran make dialyzer and saw no issues

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

CT Test Results

       7 files     202 suites   2h 17m 59s ⏱️
3 987 tests 3 921 ✔️   66 💤 0 ❌
6 322 runs  6 206 ✔️ 116 💤 0 ❌

Results for commit d16c819.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@garazdawi garazdawi self-assigned this Sep 29, 2023
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Oct 2, 2023
@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Oct 3, 2023 •
edited
Loading

I've rebased this onto maint. I'm gonna review it again, and then move it from draft.

Edit: self-review concluded.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review October 3, 2023 16:56
garazdawi
garazdawi reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a couple of files that I commented on that should not be updated.

lib/erl_docgen/priv/dtd/xhtml1-frameset.dtd Outdated Show resolved Hide resolved
lib/erl_docgen/src/docgen_xmerl_xml_cb.erl Outdated Show resolved Hide resolved
lib/xmerl/src/xmerl_otpsgml.erl Outdated Show resolved Hide resolved
@garazdawi garazdawi added fix testing currently being tested, tag is used by OTP internal CI labels Oct 6, 2023
@garazdawi
Copy link
Contributor

Everything looks fine now. Please squash the changes and I'll merge them.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Done: d16c819. Thanks much, @garazdawi.

@garazdawi garazdawi merged commit 003ead0 into erlang:maint Oct 11, 2023
20 checks passed
@garazdawi
Copy link
Contributor

Thanks!

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/code-instead-of-tt branch October 11, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garazdawi garazdawi garazdawi left review comments

Assignees

@garazdawi garazdawi

Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ferraz-oliveira @garazdawi @rickard-green