Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ct: Remove documentation for deprecated ?config #7825

Conversation

jchristgit
Copy link
Contributor

Per dcda9b5 and review of #7806, usage of CT's ?config macro is no longer recommended. Replace the documentation referencing it with proplists:get_value, which works the same way and can take an optional third argument for the default return value.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit 929a906

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s added the team:PS Assigned to OTP team PS label Nov 6, 2023
@u3s u3s self-assigned this Nov 6, 2023
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Nov 6, 2023
@u3s
Copy link
Contributor

u3s commented Nov 6, 2023

maybe let's treat this as a bug fix and target it to maint branch.

@jchristgit jchristgit changed the base branch from master to maint November 6, 2023 11:27
@jchristgit jchristgit force-pushed the remove-documentation-for-deprecated-ct-config-macro branch from 3085139 to e0bd674 Compare November 6, 2023 11:28
@u3s u3s added testing currently being tested, tag is used by OTP internal CI and removed priority:low testing currently being tested, tag is used by OTP internal CI labels Nov 7, 2023
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits as change is small and separate commits will not be worth having after review.

Per dcda9b5 and review of erlang#7806, usage of CT's `?config` macro is no
longer recommended. Replace the documentation referencing it with
`proplists:get_value`, which works the same way and can take an optional
third argument for the default return value.
@jchristgit jchristgit force-pushed the remove-documentation-for-deprecated-ct-config-macro branch from 710df91 to 929a906 Compare November 14, 2023 19:12
@u3s u3s added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Nov 15, 2023
@u3s u3s merged commit 902090b into erlang:maint Nov 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants