inets: add missing mime_type functionality to httpd #7843
Conversation
|
|
CT Test Results 2 files 21 suites 11m 45s ⏱️ Results for commit d5f1df8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
The github actions failure are due to errors in the github scripts that should now be fixed. Please rebase your branch to latest maint and they should be solved. Thanks. |
|
@erikareads your rebased branch should not include others commits. If you update your repo to include the latest maint and then checkout your branch and do:
|
c8df1d8
to
a7212dc
Compare
|
@erikareads looks good so far. You could update httpd_SUITE with a test case for the mime_type option. Look at the function server_config that you can use to make a new custom config for your test case. |
|
ping @erikareads do you need more help for test case creation? |
|
@IngelaAndin I didn't have time to focus on this today. |
|
Thanks for the PR |
Code to address #7827.
This commit contains code to patch the issue by implementing the
mime_typeoption, with thedefault_typeas a fallback.I've locally verified that this patch compiles and doesn't break existing tests,
But I'm unfamiliar with the Common Test framework for Erlang,
So I haven't yet written any automated tests.
If someone would like to contribute automated tests to this pull request,
Please do so, otherwise I will attempt to write some tests myself in the coming week.