Fix partial record matching in map generator #7878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to match part of a record in the key of a map
generator, the entire record would be matched.
Example:
-module(t).
-export([test/0]).
-record(r, {a,b}).
f(Map) ->
[V || #r{a=N} := V <- Map, is_integer(N)].
test() ->
f(#{#r{a=1} => 1, #r{a=2,b=42} => 2}).
It would be expected that `t:test()` would return `[1,2]`, but it
returned `[1]` because the entire record was matched, instead of just
field `a`. Therefore, only the first record `#r{a=1,b=undefined}`
would match.
Fixes erlang#7875
jhogberg
approved these changes
Nov 17, 2023
bd7f745
to
3de9ae0
Compare
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/6953984493 Results for commit 3de9ae0 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to match part of a record in the key of a map generator, the entire record would be matched.
Example:
It would be expected that
t:test()would return[1,2], but it returned[1]because the entire record was matched, instead of just fielda. Therefore, only the first record#r{a=1,b=undefined}would match.Fixes #7875