Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure create_table aborted reason is expected format #2320

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Ensure create_table aborted reason is expected format #2320

merged 1 commit into from
Sep 18, 2019

Conversation

lukebakken
Copy link
Contributor

According to the docs and other {aborted, _} return values, the form should be {aborted, Reason}, where Reason is a single term.

This fix makes mnesia:create_table/2 consistent with that expectation.

For instance, mnesia:error_description would work with this change:

Erlang/OTP 22 [erts-10.4.4] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]

Eshell V10.4.4  (abort with ^G)
1> mnesia:error_description(badarg).
"Bad or invalid argument, possibly bad type"
2> mnesia:error_description({aborted,badarg,foo,bag}).
{aborted,badarg,foo,bag}
3> mnesia:error_description({aborted,{badarg,foo,bag}}).
{"Bad or invalid argument, possibly bad type",foo,bag}

@lukebakken
Ensure create_table aborted reason is expected format
15e33a7 
According to the docs and other `{aborted, ` return values, the form should be
`{aborted, Reason}`, where `Reason` is a single term.

This fix makes `mnesia:create_table/2` consistent with that expectation.
@dgud dgud self-assigned this Aug 9, 2019
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Aug 9, 2019
@uabboli uabboli added team:PS Assigned to OTP team PS and removed team:MW labels Aug 21, 2019
@dgud dgud merged commit 0e0601c into erlang:master Sep 18, 2019
@lukebakken lukebakken deleted the mnesia-badarg-inconsistent branch September 18, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dgud dgud

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukebakken @dgud @uabboli @rickard-green