Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(theme-classic): fix a few margin inconsistencies #7129

Merged
merged 4 commits into from
Apr 9, 2022
Merged

refactor(theme-classic): fix a few margin inconsistencies #7129

merged 4 commits into from
Apr 9, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 7, 2022

Motivation

Yes

Have you read the Contributing Guidelines on pull requests?

These are mainly fixes to ensure consistency in design, such as removing extra spacing, eg:

image

image

Test Plan

Preview, nothing critical.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 7, 2022
@lex111 lex111 added pr: polish This PR adds a very minor behavior improvement that users will enjoy. and removed CLA Signed Signed Facebook CLA labels Apr 7, 2022
lex111
lex111 commented Apr 7, 2022
View reviewed changes
packages/docusaurus-theme-classic/src/theme/NavbarItem/LocaleDropdownNavbarItem/index.tsx
@@ -60,7 +60,7 @@ export default function LocaleDropdownNavbarItem({
label={
<span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remember to remove the parent span during next updating of Infima.

lex111
lex111 commented Apr 7, 2022
View reviewed changes
packages/docusaurus-theme-classic/src/theme/BlogSidebar/Desktop/styles.module.css
@@ -29,6 +29,7 @@

.sidebarItemLink {
color: var(--ifm-font-color-base);
display: block;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the sake of uniformity -- since all the links in such blocks (sidebars, toc) are full-width.

@netlify
Copy link

netlify bot commented Apr 7, 2022 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit ebc46f9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62504aa970f61d0008c83727
😎 Deploy Preview https://deploy-preview-7129--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7129--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

Size Change: +385 B (0%)

Total Size: 806 kB

Filename Size Change
website/build/assets/css/styles.********.css 105 kB +266 B (0%)
website/build/assets/js/main.********.js 612 kB +132 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/index.html 38.6 kB -13 B (0%)

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 7, 2022
@Josh-Cena Josh-Cena changed the title refactor(theme-classic): minor fixes and improvements refactor(theme-classic): fix a few bottom margin inconsistencies Apr 8, 2022
@Josh-Cena Josh-Cena changed the title refactor(theme-classic): fix a few bottom margin inconsistencies refactor(theme-classic): fix a few margin inconsistencies Apr 8, 2022
@lex111
Copy link
Contributor Author

lex111 commented Apr 8, 2022

It's all fixed, should be good this time.

@Josh-Cena
Copy link
Collaborator

The details margin is not applied:

image

@lex111
Copy link
Contributor Author

lex111 commented Apr 8, 2022

Try to refresh this page on preview site, should be ok:

image

@Josh-Cena
Copy link
Collaborator

I see 🙈 All good now

remember to remove the parent span during next updating of Infima.

Should we wait for another release?

@lex111
Copy link
Contributor Author

lex111 commented Apr 8, 2022

Should we wait for another release?

Probably shouldn't. I put it down in my notes what changes need to be made when updating Infima. I want to do few things in Infima and release its new version soon.

@slorber
Copy link
Collaborator

slorber commented Apr 8, 2022

👍

@Josh-Cena Josh-Cena merged commit d5cfa5b into main Apr 9, 2022
@Josh-Cena Josh-Cena deleted the lex111/minor-fixes-1 branch April 9, 2022 00:27
@lex111 lex111 mentioned this pull request Apr 9, 2022
Merged
@kozake kozake mentioned this pull request Apr 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lex111 @Josh-Cena @slorber @facebook-github-bot