Deal with F# 9 #3118
Merged
Deal with F# 9 #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why, but the logger was no longer printing anything to the stdout. |
dawedawe
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, F# 9 is coming in November!
There are some new syntax features that we don't support yet:
In this PR, I'm updating the compiler (syncing the source dependency) and making the bare minimum adjustments to support the new syntax. This means I'm not focusing on style and will be winging it based on best effort.
To-do:
Open questions:
FSharp.CoreandStreamJsonRpc, but I'm unsure of the consequences. I'm most concerned about Update FSharp.Core fantomas-for-vs#55.net8.0.Follow up:
//cc @dawedawe @josh-degraw