Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Document API using Swagger (or equivalent) (hackathon idea) #653

Open
bwalsh opened this issue Sep 24, 2015 · 10 comments
Open

Document API using Swagger (or equivalent) (hackathon idea) #653

bwalsh opened this issue Sep 24, 2015 · 10 comments

Comments

@bwalsh
Copy link
Member

bwalsh commented Sep 24, 2015

It would be useful to have the api documented using a modern interactive approach.
This might be a topic for the hackathon in NYC?
see http://swagger.io/
https://github.com/gangverk/flask-swagger

@diekhans
Copy link
Contributor

We probably have to switch the reference server away from Flask,
single it doesn't support chucked HTTP that will be required for
streaming.

bwalsh notifications@github.com writes:

It would be useful to have the api documented using a modern interactive
approach.
This might be a topic for the meeting in NYC?
see https://github.com/gangverk/flask-swagger


Reply to this email directly or view it on GitHub.*

@jeromekelleher
Copy link
Contributor

This is pretty cool @bwalsh, it would be a really neat feature. I have two slight concerns:

  1. As @diekhans, we might have to move away from Flask when we start making a streaming protocol as WSGI doesn't support HTTP chunked encoding (which is ridiculous, but what can you do).
  2. Our API isn't particularly clean REST, and might not fit into what's expected from a REST documentation generator.

No reason we can't play around with it and see what happens though!

@bwalsh bwalsh changed the title Document API using Swagger (or equivalent) Document API using Swagger (or equivalent) (hackathon idea) Oct 1, 2015
@bwalsh
Copy link
Member Author

bwalsh commented Oct 1, 2015

See http://rest.ensembl.org/documentation/info/gacallSet for another example

@kozbo
Copy link
Contributor

kozbo commented Apr 21, 2016

See http://ga4gh-demo.westus.cloudapp.azure.com for another example.

@david4096
Copy link
Member

The current state of work is reflected here. I propose future discussion about API descriptions happen there, or in the schemas. @bwalsh @jeromekelleher , OK to close?

@jeromekelleher
Copy link
Contributor

I'm happy to close this as we've moved on a long way from this point now.

I notice the link above points to one of your repos @david4096 --- is there an official GA4GH repo for this? We should have one, it's a great documentation/developer tool that anyone should be able to deploy against any GA4GH server.

@david4096
Copy link
Member

@jeromekelleher Not yet, and I agree! I expect that after we migrate to protocol buffers we will automate some part of generating API descriptions.

@jeromekelleher
Copy link
Contributor

OK, I'm going to close this issue then as we're decoupling this from the ref server.

@david4096
Copy link
Member

Although the UI isn't maintained with this code, we should provide a way to easily serve static API documentation.

@david4096 david4096 added this to the v0.3.7 milestone Dec 7, 2016
@kozbo kozbo modified the milestones: 2017-00 v0.3.6, 2017-01 Feb 24, 2017
@kozbo kozbo modified the milestones: 2017-01 v0.3.7, 2017-00 v0.3.6 Feb 27, 2017
@kozbo
Copy link
Contributor

kozbo commented Mar 2, 2017

Currently not working for 1kgenomes.ga4gh.org

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants