Show Current Month When Future Month Start Date is Provided #28042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a changelog for this :) |
|
CI Results: |
|
Build Results: |
VioletHynes
reviewed
Aug 9, 2024
changelog/28042.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| activity: The sys/internal/counters/activity endpoint will return current month data when the start_date parameter is set to a future date. | |||
There was a problem hiding this comment.
Suggested change
| activity: The sys/internal/counters/activity endpoint will return current month data when the start_date parameter is set to a future date. | |
| activity: Fixed issue where sys/internal/counters/activity endpoint would not return current month data when the end_date parameter is set to a future date. |
There was a problem hiding this comment.
Some of this is subjective wording, but it should be end_date, not start_date. Feel free to take just the end_date fix
VioletHynes
approved these changes
Aug 9, 2024
Closed
6 tasks
miagilepner
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Show current month data * Added changelog * Edited changelog
miagilepner
added a commit
that referenced
this pull request
Aug 15, 2024
* Handle Query Updates (#27547) * Simplify handle query to return updated estimation values * Added changelog * remove comment * Revert "Simplify handle query to return updated estimation values" This reverts commit b67969c. * temp * Revert "temp" This reverts commit 4932979. * CE files handle query update * Revert "CE files handle query update" This reverts commit 8dafa2d. * CE Changes * Delete vault/external_tests/upgrade_testing/upgrade_testing_binary/upgrade_test.go * Sort namespaces, mounts, and clients before adding them to HLL (#28062) * sort namespaces and mounts before adding them * also sort clients * add comments * pr comment fixes * changelog * changelog update * cleanup after handlequery changes (#27776) * Show Current Month When Future Month Start Date is Provided (#28042) * Show current month data * Added changelog * Edited changelog * Client Count Docs Updates/Cleanup (#27862) * Docs changes * More condensation of docs * Added some clarity on date ranges * Edited wording' * Added estimation client count info * Update website/content/api-docs/system/internal-counters.mdx Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENT PR :
https://github.com/hashicorp/vault-enterprise/pull/6427
Adjusts the query response to include current month data when endTime = future date. Once this is approved, I will make a subsequent CE PR.
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.