Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix toast message text when deleting a kv v2 secret #28093

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Aug 15, 2024

Description

Fixes an incorrect flash message when deleting a secret that says Successfully created:
image

after fix Successfully deleted or Successfully destroyed

Screenshot 2024-08-15 at 10 25 05 AM

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.16.8 milestone Aug 15, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner August 15, 2024 17:25
@hellobontempo hellobontempo added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x labels Aug 15, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 15, 2024
@hellobontempo hellobontempo changed the title UI/fix kv delete flash UI: Fix toast message text when deleting a kv v2 secret Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 15, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the test coverage 🚢

@hellobontempo hellobontempo merged commit 08a999f into main Aug 15, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/fix-kv-delete-flash branch August 15, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants