Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes and knowns issues for aws auth external id bug #28129

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Aug 20, 2024

No description provided.

@kpcraig kpcraig requested a review from a team as a code owner August 20, 2024 19:14
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 20, 2024
@kpcraig kpcraig modified the milestones: 1.17.4, 1.18.0-rc Aug 20, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@@ -0,0 +1,14 @@
### AWS Auth Role configuration requires an external_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### AWS Auth Role configuration requires an external_id
### AWS authN role configuration requires an external ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this suggestion mean to include the capital N?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. "auth" can be ambiguous, so we include the 'N' or 'Z' to differentiate between authentication (authN) and authorization (authZ)

kpcraig and others added 2 commits August 20, 2024 23:50
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I'll be OOO and don't want to be a blocker. Please apply the last suggestion before merging

@ldilalla-HC ldilalla-HC modified the milestones: 1.17.4, 1.17.5 Aug 28, 2024
@elliesterner elliesterner merged commit d01db33 into main Sep 12, 2024
34 checks passed
@elliesterner elliesterner deleted the VAULT-28853/aws-external-id-doc branch September 12, 2024 15:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants