Add support for bigtiff #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geosynopsis
reviewed
Aug 25, 2023
There was a problem hiding this comment.
@jmigueldelgado Great PR! 🎉 I have a few comments. As a general remark, there are a lot of formatting changes unrelated to the PR, perhaps adjusting the local formatting of this project might help to resolve it.
test.py
Outdated
|
|
||
| BIG_TIFF_PACKAGE: str = "compressed_asset.large.zip" | ||
| TIFF_PACKAGE: str = "compressed_asset.zip" | ||
| PARENT_PATH: str = "/Users/jose.delgado/delivery_data" |
There was a problem hiding this comment.
suggestion: Please remove the information from the local file system.
There was a problem hiding this comment.
This file went unintendendly into the PR, will remove.
test.py
Outdated
| for key, value in header.items(): | ||
| if value.tag == 34737: | ||
| print(value.values) | ||
| # print(header) |
test.py
Outdated
Comment on lines
22
to
55
| """ | ||
| Struggling with the following byte string: b'E\x00\x00\x7fC\xb0\xd4\x00' | ||
|
|
||
| - `E` is a shift-out character with no practical use https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters | ||
| - `\x7f` is a delete charater https://en.wikipedia.org/wiki/Delete_character | ||
| - `C` is form feed, or page break https://en.wikipedia.org/wiki/Page_break | ||
| - `\x00` is NULL and every ASCII string should end in a NULL | ||
|
|
||
| So the byte string should break into something like: | ||
| b'\x00\x00' | ||
| b'\xb0\xd4\x00' | ||
|
|
||
| Also from the tiff specification: | ||
|
|
||
| Note on ASCII Keys: | ||
|
|
||
| Special handling is required for | ||
| ASCII-valued keys. While it is true that | ||
| TIFF 6.0 permits multiple NULL-delimited | ||
| strings within a single ASCII tag, the secondary | ||
| strings might not appear in the output of naive "tiffdump" | ||
| programs. For this reason, the null delimiter of each | ||
| ASCII Key value shall be converted to | ||
| a "|" (pipe) character before being | ||
| installed back into the ASCII holding | ||
| tag, so that a dump of the tag will look like this. | ||
|
|
||
| "|" is b'\x7c' in hex | ||
|
|
||
| values.replace(b'b'\x7c',) | ||
|
|
||
| AsciiTag="first_value|second_value|etc...last_value|" | ||
|
|
||
| """ |
There was a problem hiding this comment.
suggestion: Add file like note.txt or something to collect those notes.
| if next_ifd == ifd: | ||
| return 0 | ||
| return next_ifd | ||
|
|
||
| def list_ifd(self) -> list: | ||
| """Return the list of IFDs in the header.""" | ||
| i = self._first_ifd() | ||
| # i = 16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: