bugfix for oinspect.object_info #14517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: The change that overwrote the object info arguments is here (#14349 - and this change seems to be have a typo - it doesn't make sense to set the object info to Looking at these two changes above, plus @smacke's PR, I'm +1 for merging this. |
Co-authored-by: Jason Grout <jason.grout@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oinspect.object_infoloses stuff passed in as kwargs. I suspect it's not intentional (previous versions ofobject_infodon't do this) and it seems to be the root cause of some CI failures when trying out new versions of IPython at Databricks. In this PR we preserve the fields passed in as kwargs.Test plan: let pre-merge tests run.