Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert proxy handler from callback to coroutine #937

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

takluyver
Copy link
Member

According to the tornado docs, the web.asynchronous decorator is deprecated in 5.1 and will be removed in 6.0. There's no direct suggested replacement; it just says to use coroutines instead.

According to the tornado docs, the web.asynchronous decorator is
deprecated in 5.1 and will be removed in 6.0. There's no direct
suggested replacement; it just says to use coroutines instead.
@takluyver
Copy link
Member Author

I'll merge this soon unless anyone wants more time to look at it (@mpacer @MSeal )

@MSeal
Copy link
Contributor

MSeal commented Jan 18, 2019

Looks good. That reminds me that we need to get the patch release going as well.

@MSeal MSeal merged commit f61cd6e into jupyter:master Jan 18, 2019
@alejopijuan
Copy link

@takluyver hey Thomas, I'm still getting the 500 Internal Server Error on the jupyter notebook. Any idea of what I should do?

@takluyver
Copy link
Member Author

If you're seeing the error this PR fixed, it's because you're using tornado 6.0a1 - a as in alpha. In that case, what you should do is go back to the stable version: pip install tornado<6. Hopefully any issues will be fixed well by the time Tornado 6 is stable.

@MSeal MSeal added this to the 5.4.1 milestone Feb 8, 2019
@minrk minrk mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants