Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write the stress test for gRPC, http, and tcp probes #115782

Open
SergeyKanzhelev opened this issue Feb 15, 2023 · 20 comments
Open

Write the stress test for gRPC, http, and tcp probes #115782

SergeyKanzhelev opened this issue Feb 15, 2023 · 20 comments
Assignees
@lanycrost @prateekaryyan @hrishikeshdkakkad @codeserra @alok1929 @clementbolin @Octopusjust @ashutosh887 @whitebeard10
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@SergeyKanzhelev
Copy link
Member

Write a new e2e test that will be marked as [Serial] and will be covering this bug fix: #89898

The test will serve as a replacement for the skipped unit test: #115329

The logic of the test will be as following:

  • Create MANY containers (see the unit test logic)
  • Each container has a liveness probe with 1s interval
  • After some time validate that neither of containers has restartCount > 0

/cc @aojea
/sig node
/kind cleanup
/priority important-soon
/area tests
/help-wanted
/good-first-issue

This is part of KEP: kubernetes/enhancements#2727 GA requirements, but also need the same tests for http and tcp.
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Write a new e2e test that will be marked as [Serial] and will be covering this bug fix: #89898

The test will serve as a replacement for the skipped unit test: #115329

The logic of the test will be as following:

  • Create MANY containers (see the unit test logic)
  • Each container has a liveness probe with 1s interval
  • After some time validate that neither of containers has restartCount > 0

/cc @aojea
/sig node
/kind cleanup
/priority important-soon
/area tests
/help-wanted
/good-first-issue

This is part of KEP: kubernetes/enhancements#2727 GA requirements, but also need the same tests for http and tcp.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: The label(s) area/tests cannot be applied, because the repository doesn't have them.

In response to this:

Write a new e2e test that will be marked as [Serial] and will be covering this bug fix: #89898

The test will serve as a replacement for the skipped unit test: #115329

The logic of the test will be as following:

  • Create MANY containers (see the unit test logic)
  • Each container has a liveness probe with 1s interval
  • After some time validate that neither of containers has restartCount > 0

/cc @aojea
/sig node
/kind cleanup
/priority important-soon
/area tests
/help-wanted
/good-first-issue

This is part of KEP: kubernetes/enhancements#2727 GA requirements, but also need the same tests for http and tcp.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 15, 2023
@Octopusjust
Copy link
Contributor

/assign

@aojea
Copy link
Member

aojea commented Feb 15, 2023

+1

@Anis-cpu-13
Copy link

Anis-cpu-13 commented Feb 15, 2023 •
edited
Loading

/assign

1 similar comment
@prateekaryyan
Copy link

/assign

@alok1929
Copy link

/assign

@clementbolin
Copy link

/assign

@lanycrost
Copy link
Contributor

/assign

@ashutosh887
Copy link

let me work on this issue now please
/assign

@lanycrost
Copy link
Contributor

@SergeyKanzhelev want to say, that I'm already working on this issue, soon I will try to run some benchmarks to understand how it working

https://github.com/lanycrost/kubernetes/blob/e2e-115782-stress-test-for-grpc-tcp-http/test/e2e/node/stress_probe.go

@Hrtkk Hrtkk removed their assignment Apr 2, 2023
@lanycrost lanycrost mentioned this issue Apr 18, 2023
Closed
@whitebeard10
Copy link

please let me help you on this
/assign

@pacoxu pacoxu mentioned this issue Aug 30, 2023
Closed
12 tasks
@codeserra
Copy link

i am interested in supporting current contributors on this.
/assign

@ndixita
Copy link
Contributor

ndixita commented Mar 9, 2024

Is this still being worked on? If not, I can take it up :) @lanycrost

@lanycrost
Copy link
Contributor

I've opened PR for this issue and waiting for approval :)

@aperrot42
Copy link

Hi @lanycrost this PR was automatically closed : #117439
Do you intend to reopen it soon ?

@lanycrost
Copy link
Contributor

Hey @aperrot42. Will squash my commits and reopen it.

@mukeshgupta7
Copy link

Hi @aperrot42 is this issue fixed, as I would like to contribute.

@hrishikeshdkakkad
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lanycrost lanycrost

@prateekaryyan prateekaryyan

@hrishikeshdkakkad hrishikeshdkakkad

@codeserra codeserra

@alok1929 alok1929

@clementbolin clementbolin

@Octopusjust Octopusjust

@ashutosh887 ashutosh887

@whitebeard10 whitebeard10

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write the stress test for gRPC, http, and tcp probes lanycrost/kubernetes