-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable errcheck
linter for test packages
#3034
Conversation
12c5d89
to
c80ae67
Compare
@viveksinghggits could you please review this PR?
how to fix this one ? |
@saima-s can you have a look into this please and try to get it merged. |
gci linters expects imports to be in order as mentioned here.
|
@saima-s do i need to fix above issue i was facing , because there are so many files having this isssue .
|
a66e609
to
81c8366
Compare
@julio-lopez test file are yet to update. |
5d9ef71
to
2ce46ee
Compare
@julio-lopez All set . Now, could you please test it ? |
Would this approach fine ? |
This is preferred whenever possible err := os.Setenv(kube.PodNSEnvVar, "test")
c.Assert(err, IsNil) |
Then , can I replicate through all test file ? |
4e3834c
to
a780611
Compare
@julio-lopez done . Could you please review ? |
errcheck
linter for test packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anishbista60 Only a minor request, see inline comment.
Thanks for doing this. This is looking good!
Signed-off-by: anishbista60 <anishbista053@gmail.com>
a780611
to
108ce57
Compare
@julio-lopez Done sir. And one thing i confused about is which issue to mention while raising next PR. if i mentioned issue |
Reference the issue simply as #2962 , do not prepend "Fixes" or "Closes" and you should be OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anishbista60
🥇Thanks for doing this.
🙏🏼
Change Overview
Enabled
errcheck
linter for test packagePull request type
Please check the type of change your PR introduces:
Issues
Test Plan