Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Cache Size Limits for kopia server start #3060

Merged

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Aug 23, 2024

Change Overview

Add Support for Cache Size Limits for command kopia server start
This PR will enable support for following flags for kopia server start command

  • --cache-directory
  • --content-cache-size-limit-mb
  • --metadata-cache-size-limit-mb

without these flags kopia server sometimes takes a lot of storage for caching in cases when we have large data to backup or restore.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat marked this pull request as draft August 23, 2024 13:59
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat marked this pull request as ready for review August 23, 2024 14:57
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/kopia/command/server_test.go Show resolved Hide resolved
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/kopia/command/server.go Outdated Show resolved Hide resolved
@r4rajat r4rajat removed the kueue label Aug 30, 2024
… args := commonArgs(&CommandArgs{ConfigFilePath: cmdArgs.ConfigFilePath, LogDirectory: cmdArgs.LogDirectory})

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat added the kueue label Aug 30, 2024
@PrasadG193
Copy link
Contributor

@r4rajat can you take a look at CI failure?

r4rajat and others added 4 commits September 4, 2024 14:26
@mergify mergify bot merged commit 40ece11 into master Sep 5, 2024
18 of 19 checks passed
@mergify mergify bot deleted the add-support-for-cache-size-limit-flags-for-kopia-server branch September 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants