[azure] Allow custom value for tail and timestamps #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to set custom values for the tail and timestamps paramter in the container instances panel. When a user wants to show the logs of an container from a container group in a dashboard panel it is now possible to set custom values for the "tail" and "timestamps" paramter. The "tail" paramter can be used to set the number of log lines which should be shown (default "10000"). The "timestamps" paramter can be used to show a timestamp infront of every log line (default "false"). We also fixed two bugs: - When a user selected a container in logs tab, the select box wasn't closed. This is now fixed and after the user selects a container the options are not shown anymore. - The second fix is in the mock client for the cost management integration, were the wrong version of the "costmanagement" package was used. With this fix we also added the missing tests for the cost management routes.
99633bb
to
a6e981d
Compare
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 44.58% 44.58%
=======================================
Files 96 96
Lines 8100 8113 +13
=======================================
+ Hits 3611 3617 +6
- Misses 4457 4462 +5
- Partials 32 34 +2
Continue to review full report at Codecov.
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to set custom values for the tail and timestamps
paramter in the container instances panel. When a user wants to show the
logs of an container from a container group in a dashboard panel it is
now possible to set custom values for the "tail" and "timestamps"
paramter.
The "tail" paramter can be used to set the number of log lines which
should be shown (default "10000"). The "timestamps" paramter can be used
to show a timestamp infront of every log line (default "false").
We also fixed two bugs:
closed. This is now fixed and after the user selects a container the
options are not shown anymore.
integration, were the wrong version of the "costmanagement" package
was used. With this fix we also added the missing tests for the cost
management routes.