[app] Fix User Authentication #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For users with a lot of teams and permissions the authentication process was broken, because we saved all the users teams and permissions within the cookie, so that the cookie could exceed the maximum size of 4096 characters. This is now fixed by just adding the users email address and team to the cookie and getting the permissions within each API call via the auth middleware.
fad1350
to
6fb54c6
Compare
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 43.77% 43.78% +0.01%
==========================================
Files 143 143
Lines 12396 12392 -4
==========================================
Hits 5426 5426
+ Misses 6829 6825 -4
Partials 141 141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users with a lot of teams and permissions the authentication process was broken, because we saved all the users teams and permissions within the cookie, so that the cookie could exceed the maximum size of 4096 characters.
This is now fixed by just adding the users email address and team to the cookie and getting the permissions within each API call via the auth middleware.