Extend overrides: Add Type Overrides #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egdelgadillo what do you think about extending overrides: {
"identity_provider.linkedin": "LinkedIn", // or { name: "LinkedIn" }
"story.content": { type: "Paragraph[]" },
"story.views_count": { type: "BigInt" },
}export type Story = {
content: Paragraph[];
viewsCount: BigInt;
}With the support of shortcuts: overrides: {
"*.linkedin": "LinkedIn", // or { name: "LinkedIn" }
"*.content": { type: "Paragraph[]" },
"views_count": { type: "BigInt" },
"*:numeric": { type: "float" },
} |
Enable the overriding of the default types, specifying the type for a single table's column, all columns matching a certain name, a database's default type, and even modify all types with the "*" selector. They're enabled by default, but they can also be disabled indivually. All tests have been updated to reflect the new behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a way of having more specificity over every type that is being generated.
This Pull Request extends the capability of overrides by adding a new property,
typeOverrideswhich features:users.name: 'SomeType')name: 'SomeType').decimal: 'number').All of these overrides also accept functions as values, to be able to run more complex calculations. They are all enabled by default but can be disabled, giving the user even more capability when combining all those rules.
I decided not to extend the already existing
overridesproperty to be able to separate the concerns, as I'm planning on extending it again in the near future, which rules may conflict with what I just added. Thus, just adding them all inside a new overrides property, to prevent rules from stepping on each other or targeting undesired columns/tables.Tests have been updated to reflect the new behavior and are now up-to-date.
Most of the changes in
main.jsare due to styles.