Replace use of block with lambda to fix wrong number of arguments err… (

#75) * Replace use of block with lambda to fix wrong number of arguments error on jruby-9.3.4.0 on docker This is a strange one. Running tests on docker, prior to this test, the call to when_complete using a block for the BiConsumer parameter would fail with the following error: ``` [2022-06-08T15:31:49,587][ERROR][logstash.inputs.azureeventhubs] Event Hub failed during initialization. {:event_hub_name=>"event_hub_name0", :exception=>#<ArgumentError: wrong number of arguments (given 0, expected 1)>, :backtrace=>["/usr/share/plugins/plugin/lib/logstash/inputs/azure_event_hubs.rb:435:in `block in run'"]} ``` Running the tests locally, this does not fail on my development machine (MacOsX x86_64), but does fail in the dockerized test environment. Attempting to create a simple reproducer against a BiConsumer also does not fail. * Changelog and version bump
logstash-plugins · Jun 13, 2022 · 232849e · 232849e
1 parent 6e5c9b2
commit 232849e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.4.4
+ - Fix: Replace use of block with lambda to fix wrong number of arguments error on jruby-9.3.4.0 [#75](https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/75)
+
 ## 1.4.3
  - Build: make log4j-api a provided dependency [#73](https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/73)
 

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.4.3
+1.4.4
diff --git a/lib/logstash/inputs/azure_event_hubs.rb b/lib/logstash/inputs/azure_event_hubs.rb
@@ -432,25 +432,25 @@ def run(queue)
             options.setInitialPositionProvider(LogStash::Inputs::Azure::LookBackPositionProvider.new(@initial_position_look_back))
           end
           event_processor_host.registerEventProcessorFactory(LogStash::Inputs::Azure::ProcessorFactory.new(queue, event_hub['codec'], event_hub['checkpoint_interval'], self.method(:decorate), event_hub['decorate_events']), options)
-              .whenComplete {|x, e|
+              .when_complete(lambda {|x, e|
                 @logger.info("Event Hub registration complete. ", :event_hub_name => event_hub_name )
                 @logger.error("Event Hub failure while registering.", :event_hub_name => event_hub_name, :exception => e, :backtrace => e.backtrace) if e
-              }
-              .then_accept {|x|
+              })
+              .then_accept(lambda {|x|
                 @logger.info("Event Hub is processing events... ", :event_hub_name => event_hub_name )
                 # this blocks the completable future chain from progressing, actual work is done via the executor service
                 while !stop?
                   Stud.stoppable_sleep(1) {stop?}
                 end
-              }
-              .thenCompose {|x|
+              })
+              .then_compose(lambda {|x|
                 @logger.info("Unregistering Event Hub this can take a while... ", :event_hub_name => event_hub_name )
                 event_processor_host.unregisterEventProcessor
-              }
-              .exceptionally {|e|
+              })
+              .exceptionally(lambda {|e|
                 @logger.error("Event Hub encountered an error.", :event_hub_name => event_hub_name , :exception => e, :backtrace => e.backtrace) if e
                 nil
-              }
+              })
               .get # this blocks till all of the futures are complete.
           @logger.info("Event Hub #{event_hub_name} is closed.")
         rescue => e